Deep copy improvements #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t consisten in transpiled and native code
This was
linked to
issues
Jan 3, 2025
|
I would say this is ready for review. While i added ~300 tests in this PR, there are lots of test still to be added. However, to unblock downstream work i think this should be ready for at least a beta release, so let's get this merged and add more tests later |
|
for future reference, here is what is missing: #48 |
HLWeil
reviewed
Jan 24, 2025
There was a problem hiding this comment.
That's some commitment 💯
Is there any test case for a nested DynamicObj? If not, I think it would be a good mind-easer to have at least 3 very basic tests for this scenario:
- DynamicObj with Single field (e.g. string) in the DynamicObj to be copied
- DynamicObj with Single field (e.g. string) in ResizeArray in the DynamicObj to be copied
- DynamicObj with Single field (e.g. string) in Dictionary in the DynamicObj to be copied
There was a problem hiding this comment.
These are the missing tests you referenced in #48?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will